Skip to content

Conversation

@doubleO8
Copy link
Contributor

@doubleO8 doubleO8 commented Mar 2, 2025

@susnux
Copy link
Contributor

susnux commented Mar 5, 2025

@doubleO8 thank you for your pull request. Could you please sign off your commit as per our contribution guidelines?
Should be as simple as git commit --amend -s.

Also please adjust your commit message to follow the conventional commits, e.g. simply:

- include 'background_color' in list of supported keys
+ fix(theming): include `background_color` in list of supported keys

@doubleO8 doubleO8 force-pushed the fix-occ-theming-config-background_color branch from d0f14f1 to da51459 Compare March 8, 2025 10:30
@doubleO8 doubleO8 requested a review from a team as a code owner March 8, 2025 10:30
@doubleO8 doubleO8 requested review from ArtificialOwl, artonge and provokateurin and removed request for a team March 8, 2025 10:30
@provokateurin provokateurin requested a review from susnux March 8, 2025 10:33
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@sorbaugh sorbaugh merged commit d905598 into nextcloud:master Mar 17, 2025
176 of 180 checks passed
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: theming:config background_color neither shown nor configurable

5 participants