Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 3, 2025

Summary

  1. Move general files delete action (thats not trashbin app!) to files tests.
  2. Delete files (move to trashbin) before loading the page so previews are not generated so they cannot lock the file.

Checklist

1. Move general files delete action (thats not trashbin app!) to files
   tests.
2. Delete files (move to trashbin) before loading the page so previews
   are not generated so they cannot lock the file.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux added 3. to review Waiting for reviews tests Related to tests labels Mar 3, 2025
@susnux susnux added this to the Nextcloud 32 milestone Mar 3, 2025
@susnux susnux requested review from artonge, come-nc and skjnldsv March 3, 2025 16:18
@come-nc
Copy link
Contributor

come-nc commented Mar 3, 2025

Copie d'écran_20250303_180401
👍

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@come-nc come-nc merged commit d2c1423 into master Mar 4, 2025
123 checks passed
@come-nc come-nc deleted the test/cypress-flakyness branch March 4, 2025 08:33
@come-nc
Copy link
Contributor

come-nc commented Mar 4, 2025

@susnux Are backports needed? Suppose at least stable31?

@susnux
Copy link
Contributor Author

susnux commented Mar 5, 2025

/backport to stable31

@susnux
Copy link
Contributor Author

susnux commented Mar 5, 2025

/backport to stable30

@backportbot
Copy link

backportbot bot commented Mar 5, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/51211/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0ed7e403

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51211/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member

skjnldsv commented Mar 5, 2025

/backport to stable29

@backportbot
Copy link

backportbot bot commented Mar 5, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/51211/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0ed7e403

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51211/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants