Skip to content

Conversation

@Justman100
Copy link

@nickvergessen nickvergessen removed their request for review March 4, 2025 08:48
@susnux
Copy link
Contributor

susnux commented Mar 4, 2025

@Justman100 thank you for the PR. Please give it a proper commit message following https://www.conventionalcommits.org/en/v1.0.0/
Also please sign off your commit (git commit -s)

@Justman100
Copy link
Author

@Justman100 thank you for the PR. Please give it a proper commit message following https://www.conventionalcommits.org/en/v1.0.0/ Also please sign off your commit (git commit -s)

In the description is written what will be fixed when merging! One can also go into the commit to see exactly what the commit changes...

@susnux
Copy link
Contributor

susnux commented Mar 4, 2025

Please refer to our contribution guidelines: https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md
We cannot accept any PR when there is no signoff on the commits.

@nickvergessen nickvergessen changed the title Fix Fix davclient package.json url Mar 5, 2025
"color": "^5.0.0",
"core-js": "^3.40.0",
"davclient.js": "github:owncloud/davclient.js.git#0.2.2",
"davclient.js": "owncloud/davclient.js#0.2.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susnux
Copy link
Contributor

susnux commented Mar 5, 2025

Thank you for your pull request!
We decided to switch to our fork of the library instead. Closed with #51267

@susnux susnux closed this Mar 5, 2025
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants