fix(theming): use plain string in t method (l10n)
#51266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
3. to review
susnux
requested review from
artonge,
skjnldsv and
sorbaugh
and removed request for
a team
susnux
force-pushed
the
fix/l10n-plain-string
branch
from
51a20c8 to
74baabd
Compare
skjnldsv
approved these changes
Mar 5, 2025
artonge
approved these changes
Mar 5, 2025
susnux
force-pushed
the
fix/l10n-plain-string
branch
from
74baabd to
6c5f246
Compare
Contributor
Author
|
/compile |
To correctly extract the translations we only can have plain strings within the `t` method. Also applied new l10n feature to move link code into translation function cleaning up a bit. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/l10n-plain-string
branch
from
6c5f246 to
c0dcac0
Compare
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To correctly extract the translations we only can have plain strings within the
tmethod.Also applied new l10n feature to move link code into translation function cleaning up a bit.
Checklist