Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 5, 2025

Backport of #51285

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Mar 5, 2025
@backportbot backportbot bot added this to the Nextcloud 29.0.13 milestone Mar 5, 2025
@nickvergessen nickvergessen force-pushed the backport/51285/stable29 branch from 313c2b4 to 847963e Compare March 5, 2025 16:14
@nickvergessen nickvergessen marked this pull request as ready for review March 5, 2025 16:14
@nickvergessen nickvergessen requested a review from skjnldsv as a code owner March 5, 2025 16:14
@nickvergessen
Copy link
Member

/compile /

Signed-off-by: nextcloud-command <[email protected]>
if (!in_array($key, $setParameters)) {
\OC_JSON::error(['message' => $l->t($key.
' Could not set configuration %s', $setParameters[0])]);
\OC_JSON::error(['message' => $l->t('Could not set configuration %1$s to %2$s', [$key, $setParameters[0]])]);

Check notice

Code scanning / Psalm

DeprecatedMethod Note

The method OC_JSON::error has been marked as deprecated
if (!in_array($key, $setParameters)) {
\OC_JSON::error(['message' => $l->t($key.
' Could not set configuration %s', $setParameters[0])]);
\OC_JSON::error(['message' => $l->t('Could not set configuration %1$s to %2$s', [$key, $setParameters[0]])]);

Check notice

Code scanning / Psalm

PossiblyNullArrayAccess Note

Cannot access array value on possibly null variable $setParameters of type array<array-key, mixed>|null
@AndyScherzinger AndyScherzinger merged commit a76595b into stable29 Mar 5, 2025
180 of 182 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/51285/stable29 branch March 5, 2025 19:51
@blizzz blizzz mentioned this pull request Mar 5, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants