Skip to content

[stable26] fix(login): Do not target PublicPage attribute as it does not exists #51290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 1 commit into from
Mar 5, 2025
Merged

[stable26] fix(login): Do not target PublicPage attribute as it does not exists #51290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(login): Do not target PublicPage attribute as it does not exists 
Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge
artonge committed Mar 5, 2025
commit dba818df7b0653eb18746ef832e1ce78381f5dfd
6 changes: 0 additions & 6 deletions lib/private/AppFramework/Middleware/FlowV2EphemeralSessionsMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
use OCP\AppFramework\Middleware;
use OCP\ISession;
use OCP\IUserSession;
use ReflectionMethod;

// Will close the session if the user session is ephemeral.
// Happens when the user logs in via the login flow v2.
Expand All @@ -36,11 +35,6 @@ public function beforeController($controller, $methodName) {
return;
}

$reflectionMethod = new ReflectionMethod($controller, $methodName);
if (!empty($reflectionMethod->getAttributes('PublicPage'))) {
return;
}

if ($this->reflector->hasAnnotation('PublicPage')) {
return;
}
Expand Down
Loading