Skip to content

[stable31] fix(login): Properly target public page with attribute #51295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 1 commit into from
Mar 5, 2025
Merged

[stable31] fix(login): Properly target public page with attribute #51295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(login): Properly target public page with attribute 
Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge @backportbot
artonge authored and backportbot[bot] committed Mar 5, 2025
commit fb41438db1a412d4766faf76fb32939f8d76f7a4
3 changes: 2 additions & 1 deletion lib/private/AppFramework/Middleware/FlowV2EphemeralSessionsMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use OC\AppFramework\Utility\ControllerMethodReflector;
use OC\Core\Controller\ClientFlowLoginV2Controller;
use OCP\AppFramework\Controller;
use OCP\AppFramework\Http\Attribute\PublicPage;
use OCP\AppFramework\Middleware;
use OCP\ISession;
use OCP\IUserSession;
Expand Down Expand Up @@ -38,7 +39,7 @@ public function beforeController(Controller $controller, string $methodName) {
}

$reflectionMethod = new ReflectionMethod($controller, $methodName);
if (!empty($reflectionMethod->getAttributes('PublicPage'))) {
if (!empty($reflectionMethod->getAttributes(PublicPage::class))) {
return;
}

Expand Down
Loading