fix(lookup-server): disable when not using global scale #51378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
changed the title
susnux
requested review from
Pytal,
artonge,
sorbaugh and
yemkareems
and removed request for
a team
susnux
force-pushed
the
fix/lookup-server-connector-v2
branch
2 times, most recently
from
4d95896 to
172b661
Compare
susnux
force-pushed
the
fix/lookup-server-connector-v2
branch
from
172b661 to
8787c75
Compare
susnux
force-pushed
the
fix/lookup-server-connector-v2
branch
from
8787c75 to
d899b57
Compare
8 tasks
ArtificialOwl
approved these changes
Mar 10, 2025
Member
ArtificialOwl
left a comment
ArtificialOwl
left a comment
There was a problem hiding this comment.
I would have preferred a single check on 'gs.enable' while commenting the original condition
susnux
force-pushed
the
fix/lookup-server-connector-v2
branch
from
d899b57 to
7ab38b3
Compare
Member
|
/backport to stable31 |
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/lookup-server-connector-v2
branch
from
7ab38b3 to
86767fb
Compare
AndyScherzinger
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of 3 commits: