-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(AppDiscover): Strip double-quotes from folder name #51379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
This comment was marked as outdated.
This comment was marked as outdated.
susnux
reviewed
Mar 10, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
EDIT: Applied the fix to the folder creation logic. |
e364d09 to
124985c
Compare
Signed-off-by: Git'Fellow <[email protected]>
124985c to
659747e
Compare
susnux
approved these changes
Mar 11, 2025
kesselb
approved these changes
Mar 11, 2025
Contributor
kesselb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? ;) I find getEtag and etag a bit weird.
Comment on lines
+134
to
+135
| $getEtag = $this->discoverFetcher->getETag() ?? date('Y-m'); | ||
| $etag = trim($getEtag, '"'); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| $getEtag = $this->discoverFetcher->getETag() ?? date('Y-m'); | |
| $etag = trim($getEtag, '"'); | |
| $etag = $this->discoverFetcher->getETag() ?? date('Y-m'); | |
| $cacheFolderName = trim($getEtag, '"'); |
This was referenced Mar 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows filename compatibilityis enabled #49516Checklist