Skip to content

Conversation

@icewind1991
Copy link
Member

Adds command occ share:list to show all shares on the system with a number of filtering options.

Obvious room for improvements in the performance of querying the shares and increasing the information shown and the number of filters available. But it should still be useful in it's current state.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 11, 2025
@icewind1991 icewind1991 added this to the Nextcloud 32 milestone Mar 11, 2025
@icewind1991 icewind1991 requested review from a team, come-nc and skjnldsv as code owners March 11, 2025 15:36
@icewind1991 icewind1991 requested review from a team and Altahrim and removed request for a team March 11, 2025 15:36
@kesselb
Copy link
Contributor

kesselb commented Mar 11, 2025

Nice, Thank you 👍

The command is failing on my remote share from bob to alice@https://server30.internal with

occ share:list 
An unhandled exception has been thrown:
TypeError: OC\Share20\Share::getStatus(): Return value must be of type int, null returned in /var/www/html/lib/private/Share20/Share.php:349
Stack trace:
#0 /var/www/html/apps/files_sharing/lib/Command/ListShares.php(88): OC\Share20\Share->getStatus()
#1 [internal function]: OCA\Files_Sharing\Command\ListShares->OCA\Files_Sharing\Command\{closure}(Object(OC\Share20\Share))
#2 /var/www/html/apps/files_sharing/lib/Command/ListShares.php(78): array_map(Object(Closure), Array)
#3 /var/www/html/3rdparty/symfony/console/Command/Command.php(326): OCA\Files_Sharing\Command\ListShares->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#4 /var/www/html/core/Command/Base.php(161): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#5 /var/www/html/3rdparty/symfony/console/Application.php(1078): OC\Core\Command\Base->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#6 /var/www/html/3rdparty/symfony/console/Application.php(324): Symfony\Component\Console\Application->doRunCommand(Object(OCA\Files_Sharing\Command\ListShares), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 /var/www/html/3rdparty/symfony/console/Application.php(175): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#8 /var/www/html/lib/private/Console/Application.php(187): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#9 /var/www/html/console.php(87): OC\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput))
#10 /var/www/html/occ(33): require_once('/var/www/html/c...')
#11 {main}

@icewind1991
Copy link
Member Author

Nice, Thank you 👍

The command is failing on my remote share from bob to alice@https://server30.internal with

Fixed

@icewind1991 icewind1991 merged commit ccaa463 into master Mar 31, 2025
194 of 198 checks passed
@icewind1991 icewind1991 deleted the share-list-cmd branch March 31, 2025 12:29
@skjnldsv skjnldsv added the pending documentation This pull request needs an associated documentation update label Apr 2, 2025
@skjnldsv
Copy link
Member

skjnldsv commented Apr 2, 2025

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants