test: speed up hotkey tests by 2.4s #51400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is about 2500% as we needed to always wait for the timeout of 500ms. As the event was already handled - compared to now where we only wait for one tick which is about 20ms. Also the tests did not work as expected - for shift and meta key they did not report the failing tests. Signed-off-by: Ferdinand Thiessen <[email protected]>
skjnldsv
approved these changes
Mar 12, 2025
artonge
reviewed
Mar 17, 2025
artonge
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
That is about 2500% as we needed to always wait for the timeout of 500ms. As the event was already handled - compared to now where we only wait for one tick which is about 20ms.
Also the tests did not work as expected - for shift and meta key they did not report the failing tests due to wrong key code sent.
Checklist