Skip to content

fix(unified-search): do not overlap search bar with button #51418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Mar 18, 2025
Merged

fix(unified-search): do not overlap search bar with button #51418

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a006eb
fix(unified-search): do not overlap search with button
susnux Mar 12, 2025
4c36100
chore: compile assets
susnux Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(unified-search): do not overlap search with button 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Mar 12, 2025
commit 9a006eb29cdb380559182437f3fe5b5d2ab4fc55
8 changes: 4 additions & 4 deletions core/src/components/UnifiedSearch/UnifiedSearchLocalSearchBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ function clearAndCloseSearch() {
// this can break at any time the component library changes
:deep(input) {
// search global width + close button width
padding-inline-end: calc(v-bind('searchGlobalButtonWidth') + var(--default-clickable-area));
padding-inline-end: calc(v-bind('searchGlobalButtonCSSWidth') + var(--default-clickable-area));
}
}
}
Expand All @@ -132,16 +132,16 @@ function clearAndCloseSearch() {
transition: width var(--animation-quick) linear;
}

// Make the position absolut during the transition
// this is needed to "hide" the button begind it
// Make the position absolute during the transition
// this is needed to "hide" the button behind it
.v-leave-active {
position: absolute !important;
}

.v-enter,
.v-leave-to {
&.local-unified-search {
// Start with only the overlayed button
// Start with only the overlay button
--local-search-width: var(--clickable-area-large);
}
}
Expand Down