Skip to content

feat(core): migrate setup to vue #51464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Mar 13, 2025
Merged

feat(core): migrate setup to vue #51464

skjnldsv merged 2 commits into from
Mar 13, 2025

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 13, 2025 •
edited
Loading

Fix #15591

  • Migrate to vue
  • Added autoconfig heads up

Screenshots

Normal Autoconfig detection Htaccess warning Setup error
2025-03-13_15-42 2025-03-13_15-40 2025-03-13_15-46 2025-03-13_15-47

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Mar 13, 2025
@skjnldsv skjnldsv self-assigned this Mar 13, 2025
@skjnldsv skjnldsv requested review from a team as code owners March 13, 2025 14:48
@skjnldsv skjnldsv requested review from Pytal, artonge and nfebe and removed request for a team March 13, 2025 14:48
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team Mar 13, 2025
@skjnldsv skjnldsv requested review from Altahrim, come-nc, marcoambrosini and susnux and removed request for a team March 13, 2025 14:48
marcoambrosini
marcoambrosini approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 13, 2025 •
edited
Loading

cc @marcoambrosini for design validation :)
I've done minimal changes from the source components, but some might needs adjusting (in nc/vue):

1️⃣ The border here looks odd/out of place compare to the rest of the inputs

image

2️⃣ I reduced the headings of the Notes, otherwise it looks very odd

image image

3️⃣ I added some spacing between inputs, otherwise it looks very cramped togethers

image

ChristophWurst
ChristophWurst approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 13, 2025

/compile

susnux
susnux reviewed Mar 13, 2025
View reviewed changes
core/src/views/Setup.vue
this.loading = true
},

checkPasswordEntropy(password: string): PasswordStrength {
Copy link
Contributor

@susnux susnux Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not part of checkPasswordStrength on the NcPasswordField?

Copy link
Member Author

@skjnldsv skjnldsv Mar 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, password_policy and capabilities are not available during setup.

This is a minimal and simple approach :)

Copy link
Contributor

@susnux susnux Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can integrate this but yes works for me. Nice work @skjnldsv ! 🚀

@nextcloud-command
chore(assets): Recompile assets
5967bc9 
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 13, 2025
@skjnldsv skjnldsv enabled auto-merge March 13, 2025 15:26
@skjnldsv skjnldsv merged commit a71ef11 into master Mar 13, 2025
190 checks passed
@skjnldsv skjnldsv deleted the feat/setup branch March 13, 2025 15:34
@susnux
Copy link
Contributor

susnux commented Mar 13, 2025

Cypress tests? 🤡

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 13, 2025

Cypress tests? 🤡

On it already! 😁

@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 13, 2025

@ChristophWurst Unfortunately not yet 6 years - missed it by 2 months 😆

@skjnldsv skjnldsv mentioned this pull request Mar 13, 2025
Merged
@joshtrichards
Copy link
Member

joshtrichards commented Mar 13, 2025

Don't have time to test today, but maybe someone else still has their test environment for this PR handy and can check if these Issues are also closed out by this PR (I suspect they are):

#43122
#45815

@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 13, 2025

@MorrisJobke fair enough. Revert?

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 13, 2025 •
edited
Loading

@MorrisJobke
@ChristophWurst Unfortunately not yet 6 years - missed it by 2 months 😆

Tom Hanks Hello GIF

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 13, 2025

Don't have time to test today, but maybe someone else still has their test environment for this PR handy and can check if these Issues are also closed out by this PR (I suspect they are):

#43122 #45815

will do 👍

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 13, 2025

Cypress tests? 🤡

#51468

@susnux susnux moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Mar 14, 2025
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 14, 2025

@skjnldsv
image

This was referenced May 12, 2025
Closed
Closed
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@kesselb kesselb mentioned this pull request Nov 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal is a code owner automatically assigned from nextcloud/server-frontend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: install and update technical debt

Projects

📁 Files team
Status: ☑️ Done

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Vue setup page

8 participants

@skjnldsv @susnux @MorrisJobke @joshtrichards @ChristophWurst @marcoambrosini @nextcloud-command