Skip to content

test(core): add setup cypress tests #51468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
Mar 13, 2025
Merged

test(core): add setup cypress tests #51468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0179cb4
feat(core): add setup cypress tests
skjnldsv Mar 13, 2025
2eea322
fix(core): setup fieldset spacing
skjnldsv Mar 13, 2025
6c0334e
chore(assets): Recompile assets
nextcloud-command Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions core/Controller/SetupController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,6 @@ public function loadAutoConfig(array $post): array {
if ($dbIsSet and $directoryIsSet and $adminAccountIsSet) {
$post['install'] = 'true';
}
$post['dbIsSet'] = $dbIsSet;
$post['directoryIsSet'] = $directoryIsSet;

return $post;
}
Expand Down
10 changes: 2 additions & 8 deletions core/src/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,16 @@ export type DbType = 'sqlite' | 'mysql' | 'pgsql' | 'oci'
export type SetupConfig = {
adminlogin: string
adminpass: string
directory: string
dbuser: string
dbpass: string
dbname: string
dbtablespace: string
dbhost: string
dbtype: DbType | ''

hasSQLite: boolean
hasMySQL: boolean
hasPostgreSQL: boolean
hasOracle: boolean
databases: Record<DbType, string>
databases: Partial<Record<DbType, string>>

dbIsSet: boolean
directory: string
directoryIsSet: boolean
hasAutoconfig: boolean
htaccessWorking: boolean
serverRoot: string
Expand Down
4 changes: 2 additions & 2 deletions core/src/utils/xhr-request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const isNextcloudUrl = (url) => {
/**
* Check if a user was logged in but is now logged-out.
* If this is the case then the user will be forwarded to the login page.
* @returns {Promise<void>}
* @return {Promise<void>}
*/
async function checkLoginStatus() {
// skip if no logged in user
Expand Down Expand Up @@ -66,7 +66,7 @@ async function checkLoginStatus() {

/**
* Clear all Browser storages connected to current origin.
* @returns {Promise<void>}
* @return {Promise<void>}
*/
export async function wipeBrowserStorages() {
try {
Expand Down
Loading
Loading