fix(files): Ensure actions never overflow filename #51471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
3. to review
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
2 tasks
skjnldsv
approved these changes
Mar 13, 2025
skjnldsv
reviewed
Mar 13, 2025
| } | ||
| } | ||
| @media screen and (max-width: 768px) { |
Member
There was a problem hiding this comment.
We cannot use vars in here, right?
Contributor
Author
There was a problem hiding this comment.
No that is not possible for media queries. We need to wait for: https://drafts.csswg.org/css-env-1/
Otherwise classes are the way to go, e.g. setting standardized classes on the body using some core JS script, for example: body.viewport-extra-small, body.viewport-small, body.viewport-medium, body.viewport-large
Pytal
approved these changes
Mar 13, 2025
susnux
force-pushed
the
fix/grid-view-actions
branch
2 times, most recently
from
de5d088 to
0c979fb
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/grid-view-actions
branch
from
0c979fb to
5f77b46
Compare
This was referenced Mar 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Small screen
Wide screen
Checklist