Remove files and enrypted folders from "Move or copy" dialog window #51484
Conversation
…olders from dialog
| .setFilter((n: Node) => { | ||
| // We only want to show folders in the file picker | ||
| // We don't want to show encrypted folders in the file picker | ||
| return !(n.attributes?.['type'] !== "directory" || n.attributes?.['is-encrypted'] === 1) | ||
| }) |
There was a problem hiding this comment.
Its possible to have them with the new e2ee within the webui. So also moving into e2ee folders should work
|
@memurats any reason you are based you PR against 29? Is this not the same in current master? |
Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Mauro Mura <[email protected]>
memurats
requested review from
a team,
ArtificialOwl,
ChristophWurst,
Pytal,
SebastianKrupinski,
artonge,
come-nc,
hamza221,
icewind1991,
julien-nc,
kesselb,
miaulalala,
nfebe,
nickvergessen,
provokateurin,
st3iny,
szaimen and
tcitworld
as code owners
ChristophWurst
removed request for
ArtificialOwl,
icewind1991 and
nickvergessen
ChristophWurst
requested review from
skjnldsv
and removed request for
ChristophWurst,
Pytal,
SebastianKrupinski,
artonge,
come-nc,
hamza221,
julien-nc,
kesselb,
miaulalala,
nfebe,
st3iny,
szaimen and
tcitworld
ChristophWurst
added
3. to review
|
Created new pull request for the master branch: #51532 |
|
Continued in #51532. We will create applicable backports via the bot later. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
memurats
deleted the
nmc/3534-movecopy-remove-files-and-enrypted-folders
branch
5 participants
In the context of the "Move or copy file" dialog it doesn't make sense to show all other files in the list or encrypted folders.
In order to improve clarity and usability, these should be filtered out.