Skip to content

[stable29] fix(profile): allow to unset phone number #51509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 2 commits into from
Mar 22, 2025
Merged

[stable29] fix(profile): allow to unset phone number #51509

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2ed25d
fix(profile): allow to reset phone number
susnux Mar 13, 2025
78a47c3
chore(assets): Recompile assets
nextcloud-command Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/settings/src/components/PersonalInfo/PhoneSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ export default {

methods: {
onValidate(value) {
if (value === '') {
return true
}

if (defaultPhoneRegion) {
return isValidPhoneNumber(value, defaultPhoneRegion)
}
Expand Down
34 changes: 34 additions & 0 deletions cypress/e2e/settings/personal-info.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,40 @@ describe('Settings: Change personal information', { testIsolation: true }, () =>
cy.get('a[href="tel:+498972101099701"]').should('be.visible')
})

it('Can set phone number with phone region', () => {
cy.contains('label', 'Phone number').scrollIntoView()
inputForLabel('Phone number').type('{selectAll}0 40 428990')
inputForLabel('Phone number').should('have.attr', 'class').and('contain', '--error')

cy.runOccCommand('config:system:set default_phone_region --value DE')
cy.reload()

cy.contains('label', 'Phone number').scrollIntoView()
inputForLabel('Phone number').type('{selectAll}0 40 428990')
handlePasswordConfirmation(user.password)

cy.wait('@submitSetting')
cy.reload()
inputForLabel('Phone number').should('have.value', '+4940428990')
})

it('Can reset phone number', () => {
cy.contains('label', 'Phone number').scrollIntoView()
inputForLabel('Phone number').type('{selectAll}+49 40 428990')
handlePasswordConfirmation(user.password)

cy.wait('@submitSetting')
cy.reload()
inputForLabel('Phone number').should('have.value', '+4940428990')

inputForLabel('Phone number').clear()
handlePasswordConfirmation(user.password)

cy.wait('@submitSetting')
cy.reload()
inputForLabel('Phone number').should('have.value', '')
})

it('Can set Website and change its visibility', () => {
cy.contains('label', 'Website').scrollIntoView()
// Check invalid input
Expand Down
Loading