Skip to content

fix(webauthn): adjust for updated library and add tests #51521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 4 commits into from
Mar 19, 2025
Merged

fix(webauthn): adjust for updated library and add tests #51521

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60dd89e
fix(core): adjust fronend code for changes in webauthn library
susnux Mar 17, 2025
a243e9c
fix(webauthn): do not require bcmath or gmp - not needed anymore
susnux Mar 17, 2025
45cfaa1
test: make cypress run in secure context and add WebAuthn tests
susnux Mar 17, 2025
8cf4920
chore: compile assets
susnux Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(core): adjust fronend code for changes in webauthn library 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Mar 19, 2025
commit 60dd89e04cf876ca6027ba6200387b014007df81
6 changes: 3 additions & 3 deletions apps/settings/src/service/WebAuthnRegistrationSerice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import type { RegistrationResponseJSON } from '@simplewebauthn/types'
import type { PublicKeyCredentialCreationOptionsJSON, RegistrationResponseJSON } from '@simplewebauthn/types'

import { translate as t } from '@nextcloud/l10n'
import { generateUrl } from '@nextcloud/router'
Expand All @@ -21,9 +21,9 @@ export async function startRegistration() {

try {
logger.debug('Fetching webauthn registration data')
const { data } = await axios.get(url)
const { data } = await axios.get<PublicKeyCredentialCreationOptionsJSON>(url)
logger.debug('Start webauthn registration')
const attrs = await registerWebAuthn(data)
const attrs = await registerWebAuthn({ optionsJSON: data })
return attrs
} catch (e) {
logger.error(e as Error)
Expand Down
14 changes: 10 additions & 4 deletions core/src/components/login/PasswordLessLoginForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,15 @@
<template>
<form v-if="(isHttps || isLocalhost) && supportsWebauthn"
ref="loginForm"
aria-labelledby="password-less-login-form-title"
class="password-less-login-form"
method="post"
name="login"
@submit.prevent="submit">
<h2>{{ t('core', 'Log in with a device') }}</h2>
<h2 id="password-less-login-form-title">
{{ t('core', 'Log in with a device') }}
</h2>

<NcTextField required
:value="user"
:autocomplete="autoCompleteAllowed ? 'on' : 'off'"
Expand Down Expand Up @@ -41,9 +45,11 @@
</NcEmptyContent>
</template>

<script>
<script type="ts">
import { browserSupportsWebAuthn } from '@simplewebauthn/browser'
import { defineComponent } from 'vue'
import {
NoValidCredentials,
startAuthentication,
finishAuthentication,
} from '../../services/WebAuthnAuthenticationService.ts'
Expand All @@ -56,7 +62,7 @@ import LoginButton from './LoginButton.vue'
import LockOpenIcon from 'vue-material-design-icons/LockOpen.vue'
import logger from '../../logger'

export default {
export default defineComponent({
name: 'PasswordLessLoginForm',
components: {
LoginButton,
Expand Down Expand Up @@ -143,7 +149,7 @@ export default {
// noop
},
},
}
})
</script>

<style lang="scss" scoped>
Expand Down
2 changes: 1 addition & 1 deletion core/src/services/WebAuthnAuthenticationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export async function startAuthentication(loginName: string) {
logger.error('No valid credentials returned for webauthn')
throw new NoValidCredentials()
}
return await startWebauthnAuthentication(data)
return await startWebauthnAuthentication({ optionsJSON: data })
}

/**
Expand Down