[stable29] fix: skip caching lastSeenQuotaUsage for remote shares #51528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
backport/51389/stable29
branch
from
a00852d to
0c5117b
Compare
kesselb
reviewed
Mar 18, 2025
| $isRemoteShare = $storage->instanceOfStorage(\OCA\Files_Sharing\External\Storage::class); | ||
|
|
||
| $ownerId = $storage->getOwner($path); | ||
| $hasOwnerId = $ownerId !== false && $ownerId !== null; |
Contributor
There was a problem hiding this comment.
OC\\User\\Manager::getDisplayName(): Argument #1 ($uid) must be of type string, null given, called in \/home\/runner\/work\/server\/server\/lib\/private\/legacy\/OC_Helper.php on line 554 in file '\/home\/runner\/work\/server\/server\/lib\/private\/User\/Manager.php' line 156
Integration tests were failing because getOwner may return null for Nextcloud 29.
This was improved for 31 with: #48094.
kesselb
force-pushed
the
backport/51389/stable29
branch
from
0c5117b to
1e9c1b4
Compare
Merged
Signed-off-by: Daniel Kesselberg <[email protected]>
AndyScherzinger
force-pushed
the
backport/51389/stable29
branch
from
1e9c1b4 to
6d8c463
Compare
provokateurin
approved these changes
Mar 28, 2025
come-nc
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #51389
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
OC\\User\\Manager::getDisplayName(): Argument #1 ($uid) must be of type string, null given, called in \/home\/runner\/work\/server\/server\/lib\/private\/legacy\/OC_Helper.php on line 554 in file '\/home\/runner\/work\/server\/server\/lib\/private\/User\/Manager.php' line 156Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.