Skip to content

Remove files and enrypted folders from "Move or copy" dialog window #51532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
memurats wants to merge 3 commits into from
Closed

Remove files and enrypted folders from "Move or copy" dialog window #51532

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f83d7bc
introduced filter in move/copy action to remove files and encrypted f…
memurats Mar 17, 2025
3f603af
Merge branch 'nextcloud:master' into nmc/master/3534-movecopy-remove-…
memurats Mar 17, 2025
123f961
Update moveOrCopyAction.ts
memurats Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/files/src/actions/moveOrCopyAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@
* @param action The action to open the file picker for
* @param dir The directory to start the file picker in
* @param nodes The nodes to move/copy
* @return The picked destination or false if cancelled by user

Check warning on line 210 in apps/files/src/actions/moveOrCopyAction.ts

View workflow job for this annotation

GitHub Actions / NPM lint 

Missing JSDoc @return type
*/
async function openFilePickerForAction(
action: MoveCopyAction,
Expand All @@ -222,6 +222,7 @@
// We don't want to show the current nodes in the file picker
return !fileIDs.includes(n.fileid)
})
.setFilter((n: Node) => (n.permissions & Permission.CREATE) === Permission.CREATE)
Copy link
Contributor

@susnux susnux Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does not work. Because you can have readonly root directories with external mounts that allow writing / groupfolder ACL.

So we should not filter directories without create permission as this also blocks navigating to perfectly valid ones.

I think we should filter for folder here to implement #50199
And then we need to disable the select button if CREATE is missing, but not hide the folder completely.

.setMimeTypeFilter([])
.setMultiSelect(false)
.startAt(dir)
Expand Down
Loading