Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 17, 2025

Summary

  • Simplify vue code
  • Use nc buttons for consistent design and not misuse links for buttons

Discussion

  • Should "Login with device" be secondary instead?

Screenshots

Old New
Bildschirmfoto_20250317_133359 Bildschirmfoto_20250317_133306
Bildschirmfoto_20250317_133354 Bildschirmfoto_20250317_133249

Checklist

@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: authentication labels Mar 17, 2025
@susnux susnux added this to the Nextcloud 32 milestone Mar 17, 2025
@susnux susnux requested a review from marcoambrosini March 17, 2025 17:42
@susnux susnux requested a review from a team as a code owner March 17, 2025 17:42
@susnux susnux requested review from Pytal, nfebe and szaimen and removed request for a team March 17, 2025 17:42
susnux added 2 commits March 18, 2025 16:40
- Simplify vue code
- Use nc buttons for consistent design

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/simplify-login-box branch from f4a3782 to 4ca0108 Compare March 18, 2025 15:41
@susnux susnux merged commit 211a3ba into master Mar 18, 2025
148 of 154 checks passed
@susnux susnux deleted the fix/simplify-login-box branch March 18, 2025 20:30
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: authentication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants