Skip to content

[stable29] fix: pass hide download attribute while creating the share to fix github issue 50788 #51580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 5 commits into from
Apr 2, 2025
Merged

[stable29] fix: pass hide download attribute while creating the share to fix github issue 50788 #51580

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
beb538f
fix: pass hide download attribute while creating the share to fix git…
yemkareems Mar 5, 2025
0f58178
fix(files_sharing): ugly hacks to update permissions on share creation
susnux Mar 5, 2025
b3d93b4
fix(files_sharing): make sure IDs are unique for HTML elements
susnux Mar 5, 2025
e1f94d0
test: add cypress tests for sharing download permission
susnux Mar 5, 2025
4676b75
chore(assets): Recompile assets
nextcloud-command Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add cypress tests for sharing download permission 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Apr 2, 2025
commit e1f94d0f6749b3203022a52bcaec6b80d1ba7a1f
4 changes: 2 additions & 2 deletions cypress/e2e/files_sharing/filesSharingUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ export function createShare(fileName: string, username: string, shareSettings: P
openSharingPanel(fileName)

cy.get('#app-sidebar-vue').within(() => {
cy.get('#sharing-search-input').clear()
cy.intercept({ times: 1, method: 'GET', url: '**/apps/files_sharing/api/v1/sharees?*' }).as('userSearch')
cy.get('#sharing-search-input').type(username)
cy.findByRole('combobox', { name: /Search for share recipients/i })
.type(`{selectAll}${username}`)
cy.wait('@userSearch')
})

Expand Down
15 changes: 12 additions & 3 deletions cypress/e2e/files_sharing/public-share/setup-public-share.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,24 @@ export function createShare(context: ShareContext, shareName: string, options: S
}

/**
* Adjust share permissions to be editable
* open link share details for specific index
*
* @param index
*/
function adjustSharePermission(): void {
export function openLinkShareDetails(index: number) {
cy.findByRole('list', { name: 'Link shares' })
.findAllByRole('listitem')
.first()
.eq(index)
.findByRole('button', { name: /Actions/i })
.click()
cy.findByRole('menuitem', { name: /Customize link/i }).click()
}

/**
* Adjust share permissions to be editable
*/
function adjustSharePermission(): void {
openLinkShareDetails(0)

cy.get('[data-cy-files-sharing-share-permissions-bundle]').should('be.visible')
cy.get('[data-cy-files-sharing-share-permissions-bundle="upload-edit"]').click()
Expand Down
Loading