Skip to content

[stable30] fix: pass hide download attribute while creating the share to fix github issue 50788 #51581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yemkareems merged 5 commits into from
Apr 2, 2025
Merged

[stable30] fix: pass hide download attribute while creating the share to fix github issue 50788 #51581

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
662de91
fix: pass hide download attribute while creating the share to fix git…
yemkareems Mar 5, 2025
adc1027
fix(files_sharing): ugly hacks to update permissions on share creation
susnux Mar 5, 2025
991c61d
fix(files_sharing): make sure IDs are unique for HTML elements
susnux Mar 5, 2025
899faa7
test: add cypress tests for sharing download permission
susnux Mar 5, 2025
cee6202
chore(assets): Recompile assets
nextcloud-command Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: pass hide download attribute while creating the share to fix git… 
…hub issue 50788

Signed-off-by: yemkareems <[email protected]>
  • Loading branch information
@yemkareems @susnux
yemkareems authored and susnux committed Apr 2, 2025
commit 662de917abb666b684322099bc6e6118446c374f
4 changes: 3 additions & 1 deletion apps/files_sharing/src/mixins/SharesMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,9 @@ export default {
// force value to string because that is what our
// share api controller accepts
propertyNames.forEach(name => {
if ((typeof this.share[name]) === 'object') {
if (this.share[name] === null || this.share[name] === undefined) {
properties[name] = ''
} else if ((typeof this.share[name]) === 'object') {
properties[name] = JSON.stringify(this.share[name])
} else {
properties[name] = this.share[name].toString()
Expand Down
9 changes: 5 additions & 4 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,12 +916,13 @@ export default {
this.creating = false
this.share = share
this.$emit('add:share', this.share)
} else {
this.$emit('update:share', this.share)
emit('update:share', this.share)
this.queueUpdate(...permissionsAndAttributes)
}

// Let's update after creation as some attrs are only available after creation
this.$emit('update:share', this.share)
emit('update:share', this.share)
this.queueUpdate(...permissionsAndAttributes)

await this.getNode()
emit('files:node:updated', this.node)

Expand Down