test(cypress): wait for button to be visible #51587
Merged
+29
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
Pytal,
artonge and
skjnldsv
and removed request for
a team
Instead of just expecting the button in the DOM. This causes flaky tests with files-renaming. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
test/cypress-flaky
branch
from
d01ba30 to
3dc38fa
Compare
Pytal
approved these changes
Mar 19, 2025
artonge
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of just expecting the button in the DOM.
This causes flaky tests with files-renaming.
Checklist