feat: Add share expiration indicator #51630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
2 times, most recently
from
09fb848 to
7d27f2c
Compare
nfebe
requested review from
artonge,
marcoambrosini,
sorbaugh,
susnux and
szaimen
and removed request for
a team and
szaimen
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
from
8034a08 to
0c73c87
Compare
marcoambrosini
approved these changes
Mar 24, 2025
Member
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
Nice @nfebe, the only thing I'd change is I'd put this new icon all the way to the left so that the copy link icons are vertically aligned.
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
from
0c73c87 to
f834b14
Compare
Contributor
Author
|
cc: @marcoambrosini |
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
from
f834b14 to
9e79113
Compare
Contributor
Author
|
/compile |
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
3 times, most recently
from
d293d79 to
94df136
Compare
skjnldsv
reviewed
Mar 25, 2025
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
from
94df136 to
15be284
Compare
skjnldsv
approved these changes
Mar 27, 2025
github-project-automation
bot
moved this from ☑️ Done
to 🏗️ In progress
in 📁 Files team
skjnldsv
requested changes
Mar 27, 2025
Shares that would expire now shows a clock icon with a popover. Signed-off-by: nfebe <[email protected]>
Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
feat/47176/show-share-expiry
branch
from
15be284 to
b8cab3a
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
skjnldsv
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shares that would expire now shows a clock icon with a popover.
Screenshots