fix(template): implement ITemplate directly #51686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Mar 25, 2025
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/template/implement-itemplate
branch
from
9b90c8e to
c50c093
Compare
st3iny
added
3. to review
st3iny
requested review from
come-nc,
icewind1991,
nfebe and
provokateurin
and removed request for
a team
This was referenced Mar 31, 2025
come-nc
reviewed
Mar 31, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
Sure, but note that OCP\Template is deprecated and the correct fix is to not use it anymore.
come-nc
approved these changes
Mar 31, 2025
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix Psalm warnings due to it not being able to detect the inheritance chain
Template->OC_Template-> ... ->ITemplate. The classOC_Templateis not public and thus not available innextcloud/ocp. The implements declaration is redundant but should fix Psalm.Examples
MissingDependency - lib/Provider/WebAuthnLoginProvider.php:19:14 - OCP\Template depends on class or interface oc_template that does not existMethodSignatureMismatch - lib/Provider/WebAuthnProvider.php:32:7 - Method OCA\TwoFactorWebauthn\Provider\WebAuthnProvider::getTemplate with return type 'OCP\Template' is different to return type 'OCP\Template\ITemplate' of inherited method OCP\Authentication\TwoFactorAuth\IProvider::getTemplateChecklist