Skip to content

Conversation

@bneumann
Copy link
Contributor

Summary

Adds the musicxml MIME types

Needed by Viewer adaptions: nextcloud/viewer#2752

Checklist

@bneumann bneumann requested a review from a team as a code owner March 25, 2025 17:17
@bneumann bneumann requested review from ArtificialOwl, icewind1991 and skjnldsv and removed request for a team March 25, 2025 17:17
@bneumann bneumann changed the title Added musicxml mimetypes feat(mime): Added musicxml mimetypes Mar 25, 2025
@bneumann
Copy link
Contributor Author

Hey, I updated the PR title to match the conventional commit pattern (sorry I overlooked that). But I can not figure out why the cypress-summary build is failing

@icewind1991
Copy link
Member

Cypress is currently blocked from running from forks as it doesn't work properly.

Can you fix the syntax error in RepairMimeTypes.php

@bneumann
Copy link
Contributor Author

Cypress is currently blocked from running from forks as it doesn't work properly.

Can you fix the syntax error in RepairMimeTypes.php

Okay, then I am happily ignoring this 😄
Fix is incoming

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from me, but your commits doesn't follow the conventional commits guidelines 🙈

Can you amend your commits do properly describe its contents?
Something like feat(mimetypes): added musicxml mimetypes

@bneumann bneumann force-pushed the musicxml-mimetype branch from 58df3c4 to 3c8198a Compare March 25, 2025 18:50
@bneumann
Copy link
Contributor Author

Yeah I overlooked that, next PR I know. Did some rebasing magic and hope it worked now. Looks like the messages are correct now

@bneumann bneumann changed the title feat(mime): Added musicxml mimetypes feat(mimetypes): Added musicxml mimetypes Mar 25, 2025
@skjnldsv skjnldsv added enhancement 4. to release Ready to be released and/or waiting for tests to finish labels Mar 25, 2025
@skjnldsv skjnldsv merged commit c4ac979 into nextcloud:master Mar 25, 2025
178 of 185 checks passed
@welcome
Copy link

welcome bot commented Mar 25, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@bneumann
Copy link
Contributor Author

bneumann commented Jun 1, 2025

@skjnldsv Hmm now that I think of it. Maybe it was not that smart of me to set the version in the RepairMimeTypes file to 32. Any chance I could make another patch on the server to bring it in earlier (like the next 31 version)?

@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants