-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(mimetypes): Added musicxml mimetypes #51703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey, I updated the PR title to match the conventional commit pattern (sorry I overlooked that). But I can not figure out why the cypress-summary build is failing |
|
Cypress is currently blocked from running from forks as it doesn't work properly. Can you fix the syntax error in RepairMimeTypes.php |
Okay, then I am happily ignoring this 😄 |
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good from me, but your commits doesn't follow the conventional commits guidelines 🙈
Can you amend your commits do properly describe its contents?
Something like feat(mimetypes): added musicxml mimetypes
58df3c4 to
3c8198a
Compare
|
Yeah I overlooked that, next PR I know. Did some rebasing magic and hope it worked now. Looks like the messages are correct now |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@skjnldsv Hmm now that I think of it. Maybe it was not that smart of me to set the version in the RepairMimeTypes file to 32. Any chance I could make another patch on the server to bring it in earlier (like the next 31 version)? |
Summary
Adds the musicxml MIME types
Needed by Viewer adaptions: nextcloud/viewer#2752
Checklist