Skip to content

fix(phpunit10): Migrate away from PHPUnit at() calls #51768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 3 commits into from
Mar 31, 2025
Merged

fix(phpunit10): Migrate away from PHPUnit at() calls #51768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a167fd
fix(phpunit10): Migrate away from PHPUnit at() calls
nickvergessen Mar 27, 2025
9ccb701
fix: Adjust data provider name
susnux Sep 19, 2024
522be60
fix(phpunit): Remove some more withConsecutive calls
nickvergessen Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Adjust data provider name 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @nickvergessen
susnux authored and nickvergessen committed Mar 27, 2025
commit 9ccb70174c139fe8b30f960edc0604f727c5e038
4 changes: 2 additions & 2 deletions tests/Core/Command/Config/App/SetConfigTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ protected function setUp(): void {
}


public function setData() {
public static function dataSet() {
return [
[
'name',
Expand All @@ -63,7 +63,7 @@ public function setData() {
}

/**
* @dataProvider setData
* @dataProvider dataSet
*
* @param string $configName
* @param mixed $newValue
Expand Down
4 changes: 2 additions & 2 deletions tests/Core/Command/Config/System/SetConfigTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ protected function setUp(): void {
}


public function setData() {
public static function dataTest() {
return [
[['name'], 'newvalue', null, 'newvalue'],
[['a', 'b', 'c'], 'foobar', null, ['b' => ['c' => 'foobar']]],
Expand All @@ -48,7 +48,7 @@ public function setData() {
}

/**
* @dataProvider setData
* @dataProvider dataTest
*
* @param array $configNames
* @param string $newValue
Expand Down
Loading