Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 28, 2025

Backport of #51336

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

function (string $gid) {
$group = $this->groupManager->get($gid);
return [
'id' => $group->getGID(),

Check notice

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method getGID on possibly null value
@Pytal Pytal force-pushed the backport/51336/stable30 branch 2 times, most recently from 249f525 to 43f3693 Compare March 28, 2025 22:23
@Pytal
Copy link
Member

Pytal commented Mar 28, 2025

Psalm failure here as well from missing #51375, cc @come-nc

Pytal added 12 commits April 1, 2025 10:17
…gination of groups

- Includes searching

Signed-off-by: Christopher Ng <[email protected]>
@backportbot backportbot bot force-pushed the backport/51336/stable30 branch from 43f3693 to 9cac821 Compare April 1, 2025 10:17
@come-nc
Copy link
Contributor

come-nc commented Apr 1, 2025

This still does not backport cleanly despite having merged #51375

There are conflicts in frontend file and I do not know enough to solve them.
Would @artonge or @susnux be up for redoing the backport and fixing the conflicts?

@artonge
Copy link
Contributor

artonge commented Apr 1, 2025

Looking into it

@artonge artonge force-pushed the backport/51336/stable30 branch 5 times, most recently from cf5a729 to 5f95423 Compare April 1, 2025 12:19
@artonge artonge marked this pull request as ready for review April 1, 2025 12:20
@artonge artonge requested a review from provokateurin as a code owner April 1, 2025 12:20
@artonge artonge force-pushed the backport/51336/stable30 branch from 5f95423 to e1c56c2 Compare April 1, 2025 12:21
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the backport/51336/stable30 branch from e1c56c2 to fcd5da1 Compare April 1, 2025 13:19
@artonge artonge requested a review from nfebe April 2, 2025 13:33
@susnux susnux merged commit a61d561 into stable30 Apr 3, 2025
181 of 192 checks passed
@susnux susnux deleted the backport/51336/stable30 branch April 3, 2025 06:46
@Altahrim Altahrim mentioned this pull request Apr 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants