-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
notification manager deterministic app call order #51800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notification manager deterministic app call order #51800
Conversation
38a083a to
b73d856
Compare
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
@gavine99 Can you run |
92e9dc6 to
2700bd6
Compare
|
I fixed CI and squashed the commits, I hope you don't mind. |
The notification manager always calls notify() of the 'main' notifications app before other notify apps, and calls other functions for other notifications apps before the 'main' notification app Signed-off-by: gavine99 <[email protected]>
2700bd6 to
ed6d76e
Compare
|
Good to force merge I think. |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Changes to allow a deterministic calling order of notification apps by the notification manager.
More detail
The notification manager will always call
notify()on the 'main' notifications app before other notification apps.The notification manager will always call
markProcessed(),count()andflush()on other notifications apps before calling it on the 'main' notification app.Reason for change
I have built, and others might build, notification apps that depend on the 'main' notification app and, therefore, require a definitive calling order by the notification manager.
No internal or external api changes.
No new tests required. no current tests changed.
No front-end changes.
No documentation updates required.
No backporting required.