Skip to content

Conversation

@gavine99
Copy link

@gavine99 gavine99 commented Mar 30, 2025

Summary

Changes to allow a deterministic calling order of notification apps by the notification manager.

More detail

The notification manager will always call notify() on the 'main' notifications app before other notification apps.
The notification manager will always call markProcessed() , count() and flush() on other notifications apps before calling it on the 'main' notification app.

Reason for change

I have built, and others might build, notification apps that depend on the 'main' notification app and, therefore, require a definitive calling order by the notification manager.

No internal or external api changes.
No new tests required. no current tests changed.
No front-end changes.
No documentation updates required.
No backporting required.

@gavine99 gavine99 requested a review from a team as a code owner March 30, 2025 05:20
@gavine99 gavine99 requested review from Altahrim, artonge and come-nc and removed request for a team March 30, 2025 05:20
@gavine99 gavine99 force-pushed the deterministic-notification-manager branch from 38a083a to b73d856 Compare March 30, 2025 06:35
@solracsf solracsf added this to the Nextcloud 32 milestone Mar 30, 2025
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@come-nc
Copy link
Contributor

come-nc commented Mar 31, 2025

@gavine99 Can you run composer run cs:fix to fix the code style please?

@nickvergessen
Copy link
Member

I fixed CI and squashed the commits, I hope you don't mind.

The notification manager always calls notify() of the 'main' notifications app
before other notify apps, and calls other functions for other notifications apps
before the 'main' notification app

Signed-off-by: gavine99 <[email protected]>
@nickvergessen nickvergessen force-pushed the deterministic-notification-manager branch from 2700bd6 to ed6d76e Compare April 1, 2025 10:27
@artonge
Copy link
Contributor

artonge commented Apr 1, 2025

Good to force merge I think.

@nickvergessen nickvergessen merged commit d4b805c into nextcloud:master Apr 1, 2025
198 of 205 checks passed
@welcome
Copy link

welcome bot commented Apr 1, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv removed this from the Nextcloud 32 milestone Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants