fix(federation): allows equal signs in federation id #51994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
requested review from
artonge,
icewind1991 and
yemkareems
and removed request for
a team
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
artonge
approved these changes
Apr 7, 2025
ArtificialOwl
force-pushed
the
fix/noid/allows-some-char-from-federationid
branch
from
8554919 to
00b53b3
Compare
Member
Author
done! |
ArtificialOwl
force-pushed
the
fix/noid/allows-some-char-from-federationid
branch
from
00b53b3 to
8aac440
Compare
nickvergessen
force-pushed
the
fix/noid/allows-some-char-from-federationid
branch
from
8aac440 to
ca27a54
Compare
nickvergessen
approved these changes
Apr 14, 2025
Member
Author
|
unrelated test failure |
ArtificialOwl
force-pushed
the
fix/noid/allows-some-char-from-federationid
branch
from
ca27a54 to
2c0325c
Compare
Member
|
You just force pushed away my added "not-empty test" |
nickvergessen
force-pushed
the
fix/noid/allows-some-char-from-federationid
branch
from
2c0325c to
fb4d0e9
Compare
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
fix/noid/allows-some-char-from-federationid
branch
from
fb4d0e9 to
743924c
Compare
This was referenced Apr 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a equalsign
=in your userid is a blocker for federation.The equal sign is usually filtered during creation of a new user, unless using SSO.
Assuming having an equal sign in your userId/federationId does not bring security issue,
this fix allows remote users with equal sign to be part of the federation.