-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: move file cache from view to node api #52000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
icewind1991
wants to merge
3
commits into
master
Choose a base branch
from
files-cache-node
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OC\Core\BackgroundJobs; | ||
|
|
||
| use OC\Cache\File; | ||
| use OCP\AppFramework\Utility\ITimeFactory; | ||
| use OCP\BackgroundJob\TimedJob; | ||
| use OCP\IAppConfig; | ||
| use OCP\IUserManager; | ||
| use Psr\Log\LoggerInterface; | ||
|
|
||
| class FileCacheGcJob extends TimedJob { | ||
| public function __construct( | ||
| ITimeFactory $time, | ||
| private readonly LoggerInterface $logger, | ||
| private readonly IAppConfig $appConfig, | ||
| private readonly IUserManager $userManager, | ||
| ) { | ||
| parent::__construct($time); | ||
|
|
||
| $this->setTimeSensitivity(self::TIME_INSENSITIVE); | ||
| $this->setInterval(24 * 60 * 60); | ||
| } | ||
|
|
||
| protected function run(mixed $argument): void { | ||
| $offset = $this->appConfig->getValueInt('core', 'files_gc_offset'); | ||
|
|
||
| $users = $this->userManager->getSeenUsers($offset); | ||
| $start = time(); | ||
| $count = 0; | ||
| foreach ($users as $user) { | ||
| $cache = new File(); | ||
| try { | ||
| $cache->gc($user); | ||
| } catch (\Exception $e) { | ||
| $this->logger->warning('Exception when running cache gc.', [ | ||
| 'app' => 'core', | ||
| 'exception' => $e, | ||
| ]); | ||
| } | ||
| $count++; | ||
| $now = time(); | ||
|
|
||
| // almost time for the next job run, stop early and save our location | ||
| if ($now - $start > 23 * 60 * 60) { | ||
| $this->appConfig->setValueInt('core', 'files_gc_offset', $offset + $count); | ||
| return; | ||
| } | ||
| } | ||
| $this->appConfig->setValueInt('core', 'files_gc_offset', 0); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /** | ||
| * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
| namespace OC\Repair\NC32; | ||
|
|
||
| use OC\Core\BackgroundJobs\FileCacheGcJob; | ||
| use OCP\BackgroundJob\IJobList; | ||
| use OCP\Migration\IOutput; | ||
| use OCP\Migration\IRepairStep; | ||
|
|
||
| class AddFileCacheGcBackgroundJob implements IRepairStep { | ||
| public function __construct( | ||
| private readonly IJobList $jobList, | ||
| ) { | ||
| } | ||
|
|
||
| public function getName(): string { | ||
| return 'Add background job to cleanup file cache'; | ||
| } | ||
|
|
||
| public function run(IOutput $output) { | ||
| $this->jobList->add(FileCacheGcJob::class); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.