Skip to content

fix(files_sharing): file request pass empty string if password or expiration is disabled #52072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 3 commits into from
Apr 15, 2025
Merged

fix(files_sharing): file request pass empty string if password or expiration is disabled #52072

skjnldsv merged 3 commits into from
Apr 15, 2025

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 9, 2025

Fix #52064

  • Tests to cover more cases on null/undefined behaviour change

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Apr 9, 2025
@skjnldsv skjnldsv self-assigned this Apr 9, 2025
@skjnldsv skjnldsv requested review from a team as code owners April 9, 2025 12:51
@skjnldsv skjnldsv requested review from artonge, come-nc, sorbaugh and susnux and removed request for a team April 9, 2025 12:51
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 9, 2025

/backport to stable31

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 9, 2025

/backport to stable30

@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Apr 9, 2025
nfebe
nfebe reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@nfebe nfebe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure where $dateModification is coming from but null should not lead to it being set as an empty string?

@skjnldsv skjnldsv force-pushed the fix/sharing-exp-date branch from 47baed6 to 5f50f6e Compare April 9, 2025 13:16
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 9, 2025

/compile rebase

@oleksandr-nc
Copy link
Contributor

oleksandr-nc commented Apr 12, 2025

Can we backport this fix to the Nextcloud 30?

@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 14, 2025

Can we backport this fix to the Nextcloud 30?

See the requests of backports above 👍

@skjnldsv skjnldsv force-pushed the fix/sharing-exp-date branch from d6da5f8 to bc70e0d Compare April 14, 2025 20:47
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 14, 2025

/compile

@skjnldsv skjnldsv enabled auto-merge April 14, 2025 20:47
@nextcloud-command
chore(assets): Recompile assets
f7cb282 
Signed-off-by: nextcloud-command <[email protected]>
@skjnldsv skjnldsv disabled auto-merge April 15, 2025 07:22
@skjnldsv skjnldsv merged commit f4841e1 into master Apr 15, 2025
198 of 210 checks passed
@skjnldsv skjnldsv deleted the fix/sharing-exp-date branch April 15, 2025 07:23
This was referenced Apr 15, 2025
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfebe nfebe nfebe approved these changes

@come-nc come-nc come-nc approved these changes

@susnux susnux Awaiting requested review from susnux susnux is a code owner automatically assigned from nextcloud/server-frontend

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug feature: files feature: sharing

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: Shares created with "Create file request" and unticked "expiration date" have the expiration date set.

6 participants

@skjnldsv @oleksandr-nc @nfebe @come-nc @nextcloud-command