ci: add check to ensure composer-bin is not accidentally committed #52080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
chore-check-for-composer-bin
branch
from
98cca28 to
b7422ba
Compare
kesselb
added
3. to review
kesselb
requested review from
Altahrim,
come-nc and
nfebe
and removed request for
a team
come-nc
approved these changes
Apr 14, 2025
kesselb
commented
Apr 14, 2025
| /** | ||
| * @var bool | ||
| */ | ||
| private static $installedIsLocalDir; |
Contributor
Author
There was a problem hiding this comment.
This change is coming in from the latest composer 2.8 update (composer/composer#12269). build/autoloaderchecker.sh only looks for changes to autoload_classmap and therefore our CI is not red since the latest composer bump.
kesselb
force-pushed
the
chore-check-for-composer-bin
branch
from
b3d49f4 to
11764bd
Compare
skjnldsv
approved these changes
Apr 14, 2025
kesselb
force-pushed
the
chore-check-for-composer-bin
branch
from
11764bd to
dc53310
Compare
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
chore-check-for-composer-bin
branch
from
dc53310 to
3e9454a
Compare
kesselb
commented
Apr 15, 2025
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Set up dependencies | ||
| run: composer i |
Contributor
Author
There was a problem hiding this comment.
Running composer install will install the dev dependencies again and therefore needs to go. I'm not so sure anymore, but still think that our state in github should not contain the composer-bin-plugin.
The drone workflow did not run composer install (see #43514 and https://github.com/nextcloud/server/blob/master/autotest-checkers.sh).
Requested @susnux as reviewer for a third look if that makes sense.
susnux
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The composer-bin-plugin, as dev dependency, should not be committed.
TODO
Checklist