-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
ci: add Codecov's test analytics and bundle analysis features #52179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
artonge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @spalmurray. Looks good to me.
|
Last CI run ran into some issues with both test analytics and bundle analysis. Most recent push should resolve those issues, but we'll need a CI run to be sure. |
|
The most recent run was mostly successful. Just needed to tweak the test results uploader to always run, even on test failure. Here are the dashboards for my branch in the Codecov app: https://app.codecov.io/gh/nextcloud/server/tests/spalmurray%3Amaster |
|
@spalmurray will this change require a Codecov Pro subscription? |
|
@ChristophWurst nope! These features are free for open source use |
|
@spalmurray, please fix the conflict and the commit message syntax, then it's good to merge :) |
|
@artonge ahh no problem. Sorry about that. Figured the individual commit messages would get squashed out. Should be good now! |
|
Apologies for all the force pushing. The package-lock seems to have a conflict every time master is updated. Trying to keep it ready to merge :) |
35439a8 to
5b3848e
Compare
Signed-off-by: Spencer Murray <[email protected]>
Signed-off-by: Spencer Murray <[email protected]>
Signed-off-by: Spencer Murray <[email protected]>
Signed-off-by: Spencer Murray <[email protected]>
Signed-off-by: Spencer Murray <[email protected]>
Signed-off-by: Spencer Murray <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
nfebe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Thanks for the reviews everyone! I'll keep an eye on things to make sure this is working as expected 🥳 |
|
awesome @spalmurray ! As a side note, we should have pinned the |
Hey there! I work over at Sentry on the Codecov team and we've set a goal for adding some of our new features to open source repos already using Codecov. I'm a big fan of Nextcloud, so when I saw this repo using Codecov, it seemed like a good fit :)
What are these new features?
I see that you have PR comments disabled for our code coverage feature, so I'm keeping comments for the new features disabled as well. You'll be able to see the results of these new uploads in the Codecov app.
I think I've got this set up correctly for your CI environment, but we will see how it handles this PR and I'll make necessary changes.
Let me know if you have any questions or if something seems off with my PR.