Skip to content

Conversation

@spalmurray
Copy link
Contributor

Hey there! I work over at Sentry on the Codecov team and we've set a goal for adding some of our new features to open source repos already using Codecov. I'm a big fan of Nextcloud, so when I saw this repo using Codecov, it seemed like a good fit :)

What are these new features?

  • Test Analytics will take a report of your test results and track passes/failures and identify flaky tests.
  • Bundle Analysis will track your bundle size over time. This can be helpful for finding optimizations or being notified of large changes in bundle size.

I see that you have PR comments disabled for our code coverage feature, so I'm keeping comments for the new features disabled as well. You'll be able to see the results of these new uploads in the Codecov app.

I think I've got this set up correctly for your CI environment, but we will see how it handles this PR and I'll make necessary changes.

Let me know if you have any questions or if something seems off with my PR.

@spalmurray spalmurray marked this pull request as ready for review April 14, 2025 12:54
@spalmurray spalmurray requested review from a team as code owners April 14, 2025 12:54
@spalmurray spalmurray requested review from Altahrim, come-nc, nfebe, susnux and szaimen and removed request for a team April 14, 2025 12:54
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spalmurray. Looks good to me.

@spalmurray
Copy link
Contributor Author

Last CI run ran into some issues with both test analytics and bundle analysis. Most recent push should resolve those issues, but we'll need a CI run to be sure.

@spalmurray
Copy link
Contributor Author

The most recent run was mostly successful. Just needed to tweak the test results uploader to always run, even on test failure. Here are the dashboards for my branch in the Codecov app:

https://app.codecov.io/gh/nextcloud/server/tests/spalmurray%3Amaster
https://app.codecov.io/gh/nextcloud/server/bundles/spalmurray%3Amaster/nextcloud-array-push

@ChristophWurst
Copy link
Member

@spalmurray will this change require a Codecov Pro subscription?

@spalmurray
Copy link
Contributor Author

@ChristophWurst nope! These features are free for open source use

@artonge
Copy link
Contributor

artonge commented Apr 22, 2025

@spalmurray, please fix the conflict and the commit message syntax, then it's good to merge :)

@spalmurray spalmurray changed the title ci: Add Codecov's test analytics and bundle analysis features ci: add Codecov's test analytics and bundle analysis features Apr 22, 2025
@spalmurray
Copy link
Contributor Author

@artonge ahh no problem. Sorry about that. Figured the individual commit messages would get squashed out. Should be good now!

@spalmurray
Copy link
Contributor Author

Apologies for all the force pushing. The package-lock seems to have a conflict every time master is updated. Trying to keep it ready to merge :)

@spalmurray spalmurray force-pushed the master branch 2 times, most recently from 35439a8 to 5b3848e Compare April 28, 2025 14:29
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Contributor

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzinger AndyScherzinger merged commit f26dc79 into nextcloud:master Apr 29, 2025
186 of 195 checks passed
@welcome
Copy link

welcome bot commented Apr 29, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@spalmurray
Copy link
Contributor Author

Thanks for the reviews everyone! I'll keep an eye on things to make sure this is working as expected 🥳

@skjnldsv
Copy link
Member

skjnldsv commented Apr 30, 2025

awesome @spalmurray !
Btw, we do have templates for all of our repos, maybe it make sense to add it here (with a file check for the codecov config so it's universal across all NC repos?)
https://github.com/nextcloud/.github

As a side note, we should have pinned the codecov/test-results-action action to a hash and not just a version. For security purposes, this is the recommended way :)

@kesselb kesselb mentioned this pull request Jun 2, 2025
4 tasks
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants