fix(files_sharing): do not show download button if hide-download is…

… enabled

Signed-off-by: Ferdinand Thiessen <[email protected]>

apps/files_sharing/lib/DefaultPublicShareTemplateProvider.php

@@ -145,7 +145,7 @@ public function renderPage(IShare $share, string $token, string $path): Template
 
 		// Create the header action menu
 		$headerActions = [];
-		if ($view !== 'public-file-drop') {
+		if ($view !== 'public-file-drop' && !$share->getHideDownload()) {
 			// The download URL is used for the "download" header action as well as in some cases for the direct link
 			$downloadUrl = $this->urlGenerator->linkToRouteAbsolute('files_sharing.sharecontroller.downloadShare', [
 				'token' => $token,
@@ -156,7 +156,7 @@ public function renderPage(IShare $share, string $token, string $path): Template
 			$headerActions[] = new SimpleMenuAction('download', $this->l10n->t('Download'), 'icon-download', $downloadUrl, 0, (string)$shareNode->getSize());
 
 			// If remote sharing is enabled also add the remote share action to the menu
-			if ($this->federatedShareProvider->isOutgoingServer2serverShareEnabled() && !$share->getHideDownload()) {
+			if ($this->federatedShareProvider->isOutgoingServer2serverShareEnabled()) {
 				$headerActions[] = new ExternalShareMenuAction(
 					// TRANSLATORS The placeholder refers to the software product name as in 'Add to your Nextcloud'
 					$this->l10n->t('Add to your %s', [$this->defaults->getProductName()]),