Skip to content

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Apr 14, 2025

Summary

Allows using our existing chunked upload mechanisms on public shares as well 🚀
Needs this PR for @nextcloud/upload: nextcloud-libraries/nextcloud-upload#1705

Checklist

@provokateurin provokateurin force-pushed the feat/dav/public-share-chunked-upload branch 2 times, most recently from 1a8d67a to bb6fc88 Compare April 15, 2025 06:37
@susnux susnux requested review from come-nc and removed request for sorbaugh April 16, 2025 12:37
@provokateurin provokateurin requested a review from come-nc April 30, 2025 12:38
@susnux
Copy link
Contributor

susnux commented Apr 30, 2025

Tests need to be adjusted otherwise this seems to be good to me

There were 3 failures:

  1. OCA\DAV\Tests\Files\Sharing\FilesDropPluginTest::testValid
    Expectation failed for method name is "setUrl" when invoked 1 time(s)
    Parameter 0 for invocation Sabre\HTTP\RequestInterface::setUrl('https://example.comfiles//file.txt') does not match expected value.
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'https://example.com/file.txt'
    +'https://example.comfiles//file.txt'

/home/runner/actions-runner/_work/server/server/apps/dav/lib/Files/Sharing/FilesDropPlugin.php:89
/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/Files/Sharing/FilesDropPluginTest.php:102

  1. OCA\DAV\Tests\Files\Sharing\FilesDropPluginTest::testFileAlreadyExistsValid
    Expectation failed for method name is "setUrl" when invoked 1 time(s)
    Parameter 0 for invocation Sabre\HTTP\RequestInterface::setUrl('https://example.comfiles//file (2).txt') does not match expected value.
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'https://example.com/file (2).txt'
    +'https://example.comfiles//file (2).txt'

/home/runner/actions-runner/_work/server/server/apps/dav/lib/Files/Sharing/FilesDropPlugin.php:89
/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/Files/Sharing/FilesDropPluginTest.php:132

  1. OCA\DAV\Tests\Files\Sharing\FilesDropPluginTest::testNoSubdirPut
    Expectation failed for method name is "setUrl" when invoked 1 time(s)
    Parameter 0 for invocation Sabre\HTTP\RequestInterface::setUrl('https://example.comfiles//file (2).txt') does not match expected value.
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'https://example.com/file (2).txt'
    +'https://example.comfiles//file (2).txt'

/home/runner/actions-runner/_work/server/server/apps/dav/lib/Files/Sharing/FilesDropPlugin.php:89
/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/Files/Sharing/FilesDropPluginTest.php:175

--

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from keyboard stutter, I did not test.

@provokateurin provokateurin force-pushed the feat/dav/public-share-chunked-upload branch from 3f5c992 to 46f5b07 Compare May 5, 2025 11:32
@provokateurin provokateurin requested a review from come-nc May 5, 2025 11:32
@provokateurin provokateurin requested a review from a team as a code owner May 5, 2025 13:28
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv merged commit 24c6a1f into master May 6, 2025
214 of 224 checks passed
@skjnldsv skjnldsv deleted the feat/dav/public-share-chunked-upload branch May 6, 2025 12:25
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⬆️ Allow chunked public upload

5 participants