Skip to content

[stable30] fix(files_sharing): rate limit share creation 20 times per 10 minutes #52205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 4 commits into from
Apr 15, 2025
Merged

[stable30] fix(files_sharing): rate limit share creation 20 times per 10 minutes #52205

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94d1435
fix(files_sharing): rate limit share creation 10 times per 10 minutes
skjnldsv Feb 19, 2025
c1e3bea
test: Disable ratelimit as tests trigger it
nickvergessen Apr 15, 2025
a221f72
test: enable rate limiting for ratelimiting.feature
skjnldsv Apr 15, 2025
2fdb509
fix(files_sharing): adjust rate limit share creation to 20 over 10 mi…
skjnldsv Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files_sharing): rate limit share creation 10 times per 10 minutes 
Signed-off-by: skjnldsv <[email protected]>
  • Loading branch information
@skjnldsv @backportbot
skjnldsv authored and backportbot[bot] committed Apr 15, 2025
commit 94d1435a6a5f21b4f0a8aa0be99cccb1c15baf1d
3 changes: 2 additions & 1 deletion apps/files_sharing/lib/Controller/ShareAPIController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,7 @@ public function deleteShare(string $id): DataResponse {
* 200: Share created
*/
#[NoAdminRequired]
#[UserRateLimit(limit: 10, period: 600)]
public function createShare(
?string $path = null,
?int $permissions = null,
Expand Down Expand Up @@ -2115,7 +2116,7 @@ private function checkInheritedAttributes(IShare $share): void {
* 200: The email notification was sent successfully
*/
#[NoAdminRequired]
#[UserRateLimit(limit: 5, period: 120)]
#[UserRateLimit(limit: 10, period: 600)]
public function sendShareEmail(string $id, $password = ''): DataResponse {
try {
$share = $this->getShareById($id);
Expand Down