Skip to content

[stable31] fix(files_sharing): bring back handling of hide-download on public shares #52226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 6 commits into from
Apr 27, 2025
Merged

[stable31] fix(files_sharing): bring back handling of hide-download on public shares #52226

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4314e3f
feat(files_sharing): add WebDAV property for the `hide-download` stat…
susnux Apr 14, 2025
73bcc0a
refactor(files): use new `hide-download` WebDAV property for download…
susnux Apr 14, 2025
c412f2a
fix(files_sharing): do not show download button if `hide-download` is…
susnux Apr 14, 2025
2f7e0dc
revert: do not unify `hide-download` and `prevent-download` permissions
susnux Apr 14, 2025
495bb2c
fix(files_sharing): allow to disable share download permission
susnux Apr 14, 2025
169487b
chore(assets): Recompile assets
nextcloud-command Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert: do not unify hide-download and prevent-download permissions 
Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Apr 27, 2025
commit 2f7e0dc09b5458c25349edb4145d4b0b3369eb28
5 changes: 0 additions & 5 deletions apps/files_sharing/lib/Controller/ShareAPIController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,16 +1293,11 @@ public function updateShare(
|| $share->getShareType() === IShare::TYPE_EMAIL) {

// Update hide download state
$attributes = $share->getAttributes() ?? $share->newAttributes();
if ($hideDownload === 'true') {
$share->setHideDownload(true);
$attributes->setAttribute('permissions', 'download', false);
} elseif ($hideDownload === 'false') {
$share->setHideDownload(false);
$attributes->setAttribute('permissions', 'download', true);
}
$share->setAttributes($attributes);


// If either manual permissions are specified or publicUpload
// then we need to also update the permissions of the share
Expand Down