Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 22, 2025

Summary

  • share mtime logic between both file entry components
  • remove unused mtime title (done by the NcDateTime component nowadays)
  • also restructure the mtime opacity calculation to work as expected also for old files. (it used to work because the default color of the column is already maxcontrast but this seem to me a bit flaky to depend of styles somewhere set in parent components).

Checklist

@susnux susnux added 3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Apr 22, 2025
@susnux susnux requested review from a team and skjnldsv as code owners April 22, 2025 08:00
@susnux susnux requested review from artonge and sorbaugh and removed request for a team April 22, 2025 08:00
@susnux susnux force-pushed the fix/show-better-mtime branch from fb2c9cf to c8583bc Compare April 23, 2025 17:56
@susnux
Copy link
Contributor Author

susnux commented Apr 23, 2025

/compile

susnux added 2 commits April 23, 2025 20:22
Also restructure the mtime opacity calculation to work as expected also
for old files.

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the fix/show-better-mtime branch from 23e022e to 9794f90 Compare April 23, 2025 18:22
@susnux susnux merged commit 271df14 into master Apr 23, 2025
122 checks passed
@susnux susnux deleted the fix/show-better-mtime branch April 23, 2025 18:38
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants