Skip to content

fix(objectstorage): add retry attempts to S3 connection #52361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 1 commit into from
Apr 23, 2025
Merged

fix(objectstorage): add retry attempts to S3 connection #52361

susnux merged 1 commit into from
Apr 23, 2025

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Apr 22, 2025 •
edited
Loading

Summary

Currently, there are 3 retries attempted when uploading to the object storage, but only with the legacy option.
This PR adds a retry param to the S3Client with 5 retries in standard mode as described in the documentation.

TODO

  • ...

Checklist

@miaulalala miaulalala self-assigned this Apr 22, 2025
@miaulalala miaulalala requested a review from a team as a code owner April 22, 2025 15:37
@miaulalala miaulalala requested review from ArtificialOwl and removed request for a team April 22, 2025 15:37
@miaulalala miaulalala force-pushed the fix/51833/add-retries-to-s3-client branch from 627ea05 to c456d35 Compare April 22, 2025 15:57
@miaulalala
Copy link
Contributor Author

miaulalala commented Apr 22, 2025

/backport to stable31

@miaulalala
Copy link
Contributor Author

miaulalala commented Apr 22, 2025

/backport to stable30

@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💬 Talk team Apr 22, 2025
@miaulalala miaulalala force-pushed the fix/51833/add-retries-to-s3-client branch from c456d35 to 49baa91 Compare April 23, 2025 10:15
@susnux susnux merged commit 366eb9c into master Apr 23, 2025
214 of 225 checks passed
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💬 Talk team Apr 23, 2025
@susnux susnux deleted the fix/51833/add-retries-to-s3-client branch April 23, 2025 18:40
This was referenced Apr 23, 2025
Merged
Merged
@AndyScherzinger AndyScherzinger added this to the Nextcloud 32 milestone Apr 25, 2025
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv removed this from the Nextcloud 32 milestone Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim approved these changes

@solracsf solracsf solracsf approved these changes

@provokateurin provokateurin provokateurin approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@miaulalala miaulalala

Labels

3. to review Waiting for reviews feature: object storage

Projects

💬 Talk team
Status: ☑️ Done

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

[Bug]: automatically retry requests from Nextcloud to S3

8 participants

@miaulalala @Altahrim @solracsf @provokateurin @AndyScherzinger @susnux @skjnldsv