fix(files_sharing): Improve expiration date input change handling #52364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
fix/51875/allow-keyboard-input-4-share-expiration-on-chrome
branch
from
16d2be1 to
3c4640e
Compare
susnux
reviewed
Apr 23, 2025
susnux
approved these changes
Apr 23, 2025
nfebe
force-pushed
the
fix/51875/allow-keyboard-input-4-share-expiration-on-chrome
branch
from
3c4640e to
2f6c171
Compare
Contributor
|
/backport to stable31 |
Contributor
|
/backport to stable30 |
Contributor
|
/backport to stable29 |
miaulalala
approved these changes
Apr 24, 2025
If the time picker component is emitting a Date object already, then there is redundant call of `new Date(new Date())` and therefore introduces subtle bugs, for example on chrome users could not enter expiration date with keyboard. - Use @update:model-value instead of @change/@input for more reliable date updates - Ensure null and invalid dates are handled correctly in onExpirationChange - Validate date input before updating defaultExpirationDateEnabled Resolves : #51875 Signed-off-by: nfebe <[email protected]>
susnux
force-pushed
the
fix/51875/allow-keyboard-input-4-share-expiration-on-chrome
branch
from
2f6c171 to
3c73f3f
Compare
Contributor
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
susnux
deleted the
fix/51875/allow-keyboard-input-4-share-expiration-on-chrome
branch
This was referenced Apr 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the time picker component is emitting a Date object already, then there is redundant call of
new Date(new Date())and therefore introduces subtle bugs, for example on chrome users could not enter expiration date with keyboard.Resolves : #51875