Skip to content

[stable31] chore(i18n): Use "name" instead of "nickname" #52371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 2 commits into from
Apr 24, 2025
Merged

[stable31] chore(i18n): Use "name" instead of "nickname" #52371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d249074
chore(i18n): Use "name" instead of "nickname"
rakekniven Apr 10, 2025
c0d45f8
chore(assets): Recompile assets
nextcloud-command Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(i18n): Use "name" instead of "nickname" 
Users asked why they should use a nickname?

"Name" covers nickname, pseudonym, username or real name.

Signed-off-by: rakekniven <[email protected]>
  • Loading branch information
@rakekniven @AndyScherzinger
rakekniven authored and AndyScherzinger committed Apr 24, 2025
commit d249074e9c3df4173ecd865a370dd460b1b177e3
4 changes: 2 additions & 2 deletions apps/files_sharing/src/views/PublicAuthPrompt.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
<NcTextField ref="input"
class="public-auth-prompt__input"
data-cy-public-auth-prompt-dialog-name
:label="t('files_sharing', 'Nickname')"
:placeholder="t('files_sharing', 'Enter your nickname')"
:label="t('files_sharing', 'Name')"
:placeholder="t('files_sharing', 'Enter your name')"
minlength="2"
name="name"
required
Expand Down
4 changes: 2 additions & 2 deletions cypress/e2e/files_sharing/file-request.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ const enterGuestName = (name: string) => {
cy.findByRole('dialog', { name: /Upload files to/ })
.should('be.visible')
.within(() => {
cy.findByRole('textbox', { name: 'Nickname' })
cy.findByRole('textbox', { name: 'Name' })
.should('be.visible')

cy.findByRole('textbox', { name: 'Nickname' })
cy.findByRole('textbox', { name: 'Name' })
.type(`{selectall}${name}`)

cy.findByRole('button', { name: 'Submit name' })
Expand Down
Loading