feat: add option to include external storage when transfering files #52378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
transfer-external-storage
branch
2 times, most recently
from
1a68cef to
853b2af
Compare
icewind1991
added
3. to review
icewind1991
requested review from
Altahrim,
artonge and
come-nc
and removed request for
a team
artonge
approved these changes
May 5, 2025
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Minor nitpicks, but looks good
come-nc
reviewed
May 5, 2025
come-nc
reviewed
May 5, 2025
icewind1991
force-pushed
the
transfer-external-storage
branch
from
853b2af to
397d30b
Compare
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
transfer-external-storage
branch
from
397d30b to
3a02d94
Compare
come-nc
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any external storage mounted for the source user will be skipped during the transfer.
This adds an option to also transfer all files from those external storages. This will not setup an external storage for the target user but instead copy the file to the target users home.
Additionally the transfer command now correctly handles the case where the root of the transferred files is the root of a mountpoint.