Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Apr 24, 2025

  • Resolves: none

Summary

There is no reason to force a view and timerange here. We can just use the simplified direct route as the object id is the only thing known in the activity.

['name' => 'view#index', 'url' => '/edit/{objectId}', 'verb' => 'GET', 'postfix' => 'direct.edit'],

Checklist

@st3iny st3iny added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Apr 24, 2025
@st3iny st3iny added this to the Nextcloud 32 milestone Apr 24, 2025
@st3iny st3iny self-assigned this Apr 24, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Apr 24, 2025
@tcitworld
Copy link
Member

Checkout nodb tests though

@st3iny st3iny force-pushed the fix/caldav/use-direct-route-event-activity branch from 1ded873 to cf319ae Compare April 25, 2025 18:35
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish feature: activity and notification and removed 3. to review Waiting for reviews labels Apr 25, 2025
@st3iny st3iny enabled auto-merge April 25, 2025 18:35
@AndyScherzinger AndyScherzinger force-pushed the fix/caldav/use-direct-route-event-activity branch from cf319ae to 696d76f Compare June 1, 2025 12:05
@st3iny st3iny merged commit 899b202 into master Jun 1, 2025
208 of 215 checks passed
@st3iny st3iny deleted the fix/caldav/use-direct-route-event-activity branch June 1, 2025 13:32
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Jun 1, 2025
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: activity and notification feature: caldav Related to CalDAV internals

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

5 participants