Skip to content

fix(files_sharing): Show remote shares as external #52423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfebe merged 3 commits into from
Apr 28, 2025
Merged

fix(files_sharing): Show remote shares as external #52423

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26cb5eb
fix(files_sharing): Show remote shares in external shares section
nfebe Apr 24, 2025
6454cb5
perf(files_sharing): Change sharing filtering from O(3n) to O(n)
nfebe Apr 24, 2025
3bdc173
chore(assets): Recompile assets
nextcloud-command Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
perf(files_sharing): Change sharing filtering from O(3n) to O(n) 
Replaced multiple Array.filter() calls with a single loop to improve performance.
This avoids redundant iterations over the shares array and categorizes them more efficiently.

Signed-off-by: nfebe <[email protected]>
  • Loading branch information
@nfebe
nfebe committed Apr 25, 2025
commit 6454cb51242428a48b9929c6a28ad9b681ef8ba0
12 changes: 9 additions & 3 deletions apps/files_sharing/src/views/SharingTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,9 +365,15 @@ export default {
],
)

this.linkShares = shares.filter(share => [ShareType.Link, ShareType.Email].includes(share.type))
this.shares = shares.filter(share => ![ShareType.Link, ShareType.Email, ShareType.Remote, ShareType.RemoteGroup].includes(share.type))
this.externalShares = shares.filter(share => [ShareType.Remote, ShareType.RemoteGroup].includes(share.type))
for (const share of shares) {
if ([ShareType.Link, ShareType.Email].includes(share.type)) {
this.linkShares.push(share)
} else if ([ShareType.Remote, ShareType.RemoteGroup].includes(share.type)) {
this.externalShares.push(share)
} else {
this.shares.push(share)
}
}

logger.debug(`Processed ${this.linkShares.length} link share(s)`)
logger.debug(`Processed ${this.shares.length} share(s)`)
Expand Down
Loading