build(deps): bump nextcloud/coding-standard from 1.2.1 to 1.2.2 in /vendor-bin/cs-fixer #52462
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nextcloud-command
left a comment
nextcloud-command
left a comment
There was a problem hiding this comment.
@dependabot merge
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
susnux
requested review from
Altahrim,
CarlSchwan,
ChristophWurst,
SebastianKrupinski,
hamza221,
kesselb,
miaulalala,
nickvergessen,
provokateurin,
st3iny and
tcitworld
as code owners
susnux
removed request for
a team,
CarlSchwan,
SebastianKrupinski,
hamza221 and
tcitworld
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Maybe ignore nextcloud coding-standard in general from updates on stable?
Even though I do not get why a patch release causes so many changes, should have been a minor release when rules were added?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -276,8 +276,8 @@ | |||
| if (function_exists('disk_free_space')) { | |||
| $df = disk_free_space($this->configDir); | |||
| $size = strlen($content) + 10240; | |||
| if ($df !== false && $df < (float)$size) { | |||
| throw new \Exception($this->configDir . " does not have enough space for writing the config file! Not writing it back!"); | |||
| if ($df !== false && $df < (float) $size) { | |||
Check notice
Code scanning / Psalm
TaintedHtml Note
| @@ -249,7 +249,7 @@ | |||
|
|
|||
| // validate the data directory | |||
| if ((!is_dir($dataDir) && !mkdir($dataDir)) || !is_writable($dataDir)) { | |||
| $error[] = $l->t("Cannot create or write into the data directory %s", [$dataDir]); | |||
| $error[] = $l->t('Cannot create or write into the data directory %s', [$dataDir]); | |||
Check notice
Code scanning / Psalm
TaintedFile Note
lib/private/legacy/OC_Files.php
Outdated
Check failure
Code scanning / Psalm
TaintedHtml Error
lib/private/legacy/OC_Files.php
Outdated
Check failure
Code scanning / Psalm
TaintedTextWithQuotes Error
I was about to agree, but I think it actually makes sense to do it in order to have less conflicts when backporting changes from master. It's really not necessary to update the code style in stable branches since we only develop on master, but for this benefit I would still do it. |
That makes sense! |
There was a problem hiding this comment.
Psalm found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
susnux
force-pushed
the
dependabot/composer/vendor-bin/cs-fixer/stable30/nextcloud/coding-standard-1.2.2
branch
from
2e66b2c to
71568b3
Compare
susnux
force-pushed
the
dependabot/composer/vendor-bin/cs-fixer/stable30/nextcloud/coding-standard-1.2.2
branch
from
71568b3 to
2a4dbf2
Compare
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](nextcloud/coding-standard@v1.2.1...v1.2.2) --- updated-dependencies: - dependency-name: nextcloud/coding-standard dependency-version: 1.2.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
dependabot/composer/vendor-bin/cs-fixer/stable30/nextcloud/coding-standard-1.2.2
branch
from
2a4dbf2 to
3cc70aa
Compare
susnux
deleted the
dependabot/composer/vendor-bin/cs-fixer/stable30/nextcloud/coding-standard-1.2.2
branch
Bumps nextcloud/coding-standard from 1.2.1 to 1.2.2.
Release notes
Sourced from nextcloud/coding-standard's releases.
Changelog
Sourced from nextcloud/coding-standard's changelog.
Commits
81fec49Merge pull request #19 from nextcloud/changelog/1.2.2d4c2638Merge pull request #26 from nextcloud/phpdoc-rules54a8064style: phpdoc align and var spacingf026c31Merge pull request #25 from nextcloud/casting-rules42b094echore(release): Add changelog for 1.2.21f070fdstyle: single quotesf8e84b5style: add rules for castsd73f7f5Merge pull request #22 from nextcloud/style-add-method-chaining014e163Merge pull request #20 from nextcloud/add-phpdoc-rulesa697951style: ensure indentation with method chainingMost Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-command.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)