Skip to content

Conversation

@RobertZenz
Copy link
Contributor

Summary

Fix incorrect parameter being passed.

Checklist

@RobertZenz RobertZenz requested a review from a team as a code owner April 26, 2025 13:24
@RobertZenz RobertZenz requested review from come-nc, skjnldsv and yemkareems and removed request for a team April 26, 2025 13:24
@susnux susnux added bug 3. to review Waiting for reviews labels Apr 27, 2025
@susnux
Copy link
Contributor

susnux commented Apr 27, 2025

/backport to stable31

@susnux
Copy link
Contributor

susnux commented Apr 27, 2025

/backport to stable30

@susnux susnux added this to the Nextcloud 32 milestone Apr 27, 2025
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 28, 2025
@come-nc
Copy link
Contributor

come-nc commented Apr 28, 2025

@sorbaugh Will need a force-merge as coming from a fork

@RobertZenz
Copy link
Contributor Author

Is 29 also a stable version this should be backported to?

@sorbaugh sorbaugh merged commit f9b6b88 into nextcloud:master Apr 29, 2025
173 of 180 checks passed
@welcome
Copy link

welcome bot commented Apr 29, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot
Copy link

backportbot bot commented Apr 29, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/52479/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f428e678

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52479/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@sorbaugh
Copy link
Contributor

Thanks for the contribution!!

@solracsf
Copy link
Member

/backport to stable30

@backportbot
Copy link

backportbot bot commented Apr 29, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/52479/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f428e678

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52479/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv removed this from the Nextcloud 32 milestone Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request bug feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Call to cacheAndAppendCombineJsonIfExist in JSResourceLocator passes $appWebRoot as parameter instead of $app.

6 participants