Skip to content

[stable31] fix: don't check node access again for listing reminders in dav #52504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 1 commit into from
Apr 29, 2025
Merged

[stable31] fix: don't check node access again for listing reminders in dav #52504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: don't check node access again for listing reminders in dav 
Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991 @backportbot
icewind1991 authored and backportbot[bot] committed Apr 28, 2025
commit 193f0326390bd2c1226b5b04ce748d90e11725de
2 changes: 1 addition & 1 deletion apps/files_reminders/lib/Dav/PropFindPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function () use ($node) {
}

$fileId = $node->getId();
$reminder = $this->reminderService->getDueForUser($user, $fileId);
$reminder = $this->reminderService->getDueForUser($user, $fileId, false);
if ($reminder === null) {
return '';
}
Expand Down
6 changes: 4 additions & 2 deletions apps/files_reminders/lib/Service/ReminderService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,10 @@ public function cacheFolder(IUser $user, Folder $folder): void {
/**
* @throws NodeNotFoundException
*/
public function getDueForUser(IUser $user, int $fileId): ?RichReminder {
$this->checkNode($user, $fileId);
public function getDueForUser(IUser $user, int $fileId, bool $checkNode = true): ?RichReminder {
if ($checkNode) {
$this->checkNode($user, $fileId);
}
/** @var null|false|Reminder $cachedReminder */
$cachedReminder = $this->cache->get("{$user->getUID()}-$fileId");
if ($cachedReminder === false) {
Expand Down
Loading