feat(files_sharing): show Account menu on public pages #52537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
force-pushed
the
fix/loading-account-menu
branch
from
1733f8f to
1527c5e
Compare
skjnldsv
added
enhancement
2. developing
skjnldsv
force-pushed
the
fix/loading-account-menu
branch
3 times, most recently
from
22d454e to
7600d21
Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
requested review from
artonge,
provokateurin,
sorbaugh and
susnux
and removed request for
a team
This comment was marked as resolved.
This comment was marked as resolved.
nextcloud-command
force-pushed
the
fix/loading-account-menu
branch
from
7600d21 to
6ca71cf
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
To be clear, this is not related to guest application, right? This is for public links pages? |
come-nc
reviewed
May 16, 2025
apps/files_sharing/lib/Listener/LoadPublicFileRequestAuthListener.php
Outdated
Show resolved
Hide resolved
susnux
reviewed
May 16, 2025
susnux
reviewed
May 16, 2025
apps/files_sharing/lib/Listener/LoadPublicFileRequestAuthListener.php
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
commented
Jun 10, 2025
Comment on lines
+172
to
+175
| // Check that the note states the current name | ||
| // cy.get('@guestIdentificationDialog') | ||
| // .findByRole('note') | ||
| // .should('contain', 'are currently identified as Jane Doe') |
Member
Author
There was a problem hiding this comment.
Needs nextcloud-libraries/nextcloud-dialogs#1841
Will adjust in followup :)
Member
Author
|
Cypress tests added! 🚀 |
AndyScherzinger
approved these changes
Jun 10, 2025
susnux
previously requested changes
Jun 11, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Generally very nice, but has invalid DOM structure breaking WCAG / BITV.
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
fix/loading-account-menu
branch
from
0000b75 to
a6fc4aa
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
nfebe
approved these changes
Jun 11, 2025
Signed-off-by: John Molakvoæ <[email protected]>
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As a guest, it's nice to be recognised on an instance, whether you join different talk rooms, answer a form or upload files to a shared folder.
As we do so, being transparent is important, and showing the user we know who they are is mandatory.
As well as some options to clear this information.
Screenshots